Skip to content

Use the Spotless predeclare DSL - #12962

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/use-spotless-predeclare
Oct 20, 2026
Merged

Use the Spotless predeclare DSL#12962
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/use-spotless-predeclare

Conversation

@bric3

@bric3 bric3 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Use spotlessPredeclare { ... } to declare the shared formatter dependencies in the root build.

Motivation

Spotless 8.5.0 added a Kotlin DSL accessor that enables dependency predeclaration directly. This removes the explicit predeclareDeps() call and extension cast.

Additional Notes

Formatter dependencies still resolve once from the root project's repositories, with the same types and versions.

Contributor Checklist

@bric3 bric3 added tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM labels Oct 20, 2026
@bric3
bric3 marked this pull request as ready for review October 20, 2026 14:36
@bric3
bric3 requested a review from a team as a code owner October 20, 2026 14:36
@bric3
bric3 requested review from PerfectSlayer and removed request for a team October 20, 2026 14:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T14:39:15.082353Z 49d8db8 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-20T14:38:32.615051Z 49d8db8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes Oct 20, 2026
View reviewed changes
Comment thread build.gradle.kts Resolved
datadog-official[bot]
datadog-official Bot reviewed Oct 20, 2026
View reviewed changes

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The pinned Spotless plugin supports spotlessPredeclare and enables the same root-project dependency provisioning as predeclareDeps(). Formatter declarations remain unchanged.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 49d8db8

@datadog-official

datadog-official Bot commented Oct 20, 2026 •
edited by datadog-prod-us1-6 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.85% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 49d8db8 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.76 s 14.66 s [+0.1%; +1.4%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.53 s 13.67 s [-1.9%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 17.16 s 16.98 s [+0.2%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent 16.88 s 17.05 s [-2.0%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.76 s 16.95 s [-2.1%; -0.2%] (maybe better)
startup:petclinic:sca:Agent 17.08 s 16.83 s [+0.4%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 16.13 s 16.08 s [-0.6%; +1.3%] (no difference)

Commit: 49d8db81 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 enabled auto-merge October 20, 2026 15:05
@bric3
bric3 added this pull request to the merge queue Oct 20, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-20 15:31:42 UTC ℹ️ Start processing command /merge

2026-10-20 15:31:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-20 16:52:36 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 20, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 59d72fa into master Oct 20, 2026
618 of 623 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/use-spotless-predeclare branch October 20, 2026 16:52
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 20, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD mentioned this pull request Nov 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-official datadog-official[bot] datadog-official[bot] left review comments
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes
@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-lang-platform-java
@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bric3 @AlexeyKuznetsov-DD